linux-mips
[Top] [All Lists]

Re: [PATCH] provide functions for gpio configuration

To: Phil Sutter <n0-1@freewrt.org>
Subject: Re: [PATCH] provide functions for gpio configuration
From: Florian Fainelli <florian@openwrt.org>
Date: Thu, 30 Oct 2008 19:16:21 +0100
Cc: Linux-Mips List <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id:sender; bh=V9Ws4t+fYscCiToRCVJfBw01aAFRt/Ptb7enXQn/wmY=; b=TTZz4tYVtgPvsYmPWrrPFGequScNZQVgP25zGbAdXFQ9hcNB67Su8jBEB5NOoD7PRA XDYgdrxoTlsfDMdfaNdnVuSOTz3T20NmhUw90owICbRFhal/8m1bYP30osZSoVG36Jal pMYuCvyuVFjv/oFwJVVq4WOxnqsPUF1M6TFp0=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id :sender; b=GUMf3/p8/0GgkhRkSnKGWEfbboPEmCjkCYd4l9S2rCL+1PdtUFCmoQvnt7fDyyqXyH gOHS6ZDckCsSXAOKFPJ0MIvPqnrs7oIwXIEG1WMAuJNLBcu+SrMTaM5UbHozRDFUDtEs X8VZbpOAjy+gLE3MMrs11HVB2DlTtCaV6wRsY=
In-reply-to: <20081030174715.GA10620@nuty>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1225310409-4440-1-git-send-email-n0-1@freewrt.org> <200810301813.05710.florian@openwrt.org> <20081030174715.GA10620@nuty>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.9
Hi Phil,

Le Thursday 30 October 2008 18:47:15 Phil Sutter, vous avez écrit :
> Sounds reasonable to me. So I'll prepare a patch which:
> * removes the function pointers from rb532_gpio_chip
> * exports getters and setters for interrupt status and level
>
> The GPIO config and function registers should indeed only be accessed at
> bootup, so the corresponding getters/setters will be only locally
> accessible in arch/mips/rb532/gpio.c. Doing it this way also prevents
> any driver from breaking others, as the complete GPIO configuration will
> be done at a single place (i.e., inside gpio.c). IIRC pata-rb532-cf did
> use them only at initialisation state and to prevent the described
> situation.

Perfect.

>
> I got the pata driver working by the way. I just wanted to get a
> solution for the GPIO problem first, as it needs to access interrupt
> level and status at least.

Great :) Good job.
-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

Attachment: signature.asc
Description: This is a digitally signed message part.

<Prev in Thread] Current Thread [Next in Thread>