linux-mips
[Top] [All Lists]

Re: [PATCH] provide functions for gpio configuration

To: Phil Sutter <n0-1@freewrt.org>
Subject: Re: [PATCH] provide functions for gpio configuration
From: Florian Fainelli <florian@openwrt.org>
Date: Thu, 30 Oct 2008 18:13:05 +0100
Cc: Linux-Mips List <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id:sender; bh=1apHrDdzgsXpX7yocXthbc9MsAGssHGA8PG9UC5HVaQ=; b=NcJpwOn6GGx+aq/QNGz5Jn3GGKGoV5r3KuKQ8LT13KMYxC78eKZ1Hpbz3mW6ppO5ze Nc1p8omRJPhuEOs4MrmBvHgiGasmhG10LhRqffsbqa/22LehLckPGhLmiH7hp6ZJuwio CQNDAoNXSJyXtttUnSgRoTfl4gQ2hCtqA/CTg=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id:sender; b=xMiaUj7iuvfPCrhzUGSjGEZ3pFfMYQB+2+Z9V9DeLa6IApebi/eJ0E5zXCzY8rAoQV xomHqCLwRg1kk9tlrYKBVFKfnmwsn1gIZZXQPcqFdl4GtjBbvP/l0bJqFB/Sh6Yrg09X 2yX0hF9pJPE/0pSE0j474iYo5wgAlCAqHq2Ik=
In-reply-to: <20081029211046.GC17108@nuty>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1225310409-4440-1-git-send-email-n0-1@freewrt.org> <200810292107.43818.florian@openwrt.org> <20081029211046.GC17108@nuty>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.9
Hi Phil,

Le Wednesday 29 October 2008 22:10:46 Phil Sutter, vous avez écrit :
> Yes it does, but that's not part of gpiolib itself. Accessing them needs
> a combination of gpio_to_chip() and container_of() to be used, which I
> doubt makes sense on a device with a single, platform gpio chip.

Yes, that makes it unexportable the way it is done yet. What I suggest is not 
overriding the struct rb532_gpio_chip with thoses callbacks, but do like you 
suggested initially.

> I'm not sure if this is absolutely true. The original CompactFlash
> driver e.g. clears interrupt level in cf_irq_handler() and sets it in
> prepare_cf_irq(). The latter function is called more than once.

This should be moved the IRQ handler, where a specific check for the IRQ being 
a GPIO one should set the interrupt status and level accordingly.

Thanks.
-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

<Prev in Thread] Current Thread [Next in Thread>