Re: [PATCH] provide functions for gpio configuration

[Florian Fainelli <florian@openwrt.org>]

Hi Phil,

Le Wednesday 29 October 2008 22:10:46 Phil Sutter, vous avez écrit :
> Yes it does, but that's not part of gpiolib itself. Accessing them needs
> a combination of gpio_to_chip() and container_of() to be used, which I
> doubt makes sense on a device with a single, platform gpio chip.

Yes, that makes it unexportable the way it is done yet. What I suggest is not 
overriding the struct rb532_gpio_chip with thoses callbacks, but do like you 
suggested initially.

> I'm not sure if this is absolutely true. The original CompactFlash
> driver e.g. clears interrupt level in cf_irq_handler() and sets it in
> prepare_cf_irq(). The latter function is called more than once.

This should be moved the IRQ handler, where a specific check for the IRQ being 
a GPIO one should set the interrupt status and level accordingly.

Thanks.
-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------