On Thu, Oct 30, 2008 at 02:10:54PM +0300, Sergei Shtylyov wrote:
> From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Date: Thu, 30 Oct 2008 14:10:54 +0300
> To: akpm@linux-foundation.org
> Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
> alessandro.zummo@towertech.it, tsbogend@alpha.franken.de
> Subject: Re: [patch 2/3] drivers/rtc/rtc-ds1286.c is borked
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>
> Hello.
>
> akpm@linux-foundation.org wrote:
>
>> From: Andrew Morton <akpm@linux-foundation.org>
>>
>> drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
>> drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function
>> '__raw_readl'
>> drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
>> drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function
>> '__raw_writel'
>> drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
>> drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function
>> 'ioremap'
>> drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer
>> without a cast
>> drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function
>> 'iounmap'
>>
>
> Again, on which architecture this happens?
On non-MIPS. <linux/io.h> is required to build the two files in question
but wasn't getting included explicitly. On MIPS we were lucky; io.h
was getting dragged in indirectly through another header so things just
happened to work.
Ralf
|