linux-mips
[Top] [All Lists]

Re: [patch 3/3] drivers/rtc/rtc-m48t35.c is borked too

To: akpm@linux-foundation.org
Subject: Re: [patch 3/3] drivers/rtc/rtc-m48t35.c is borked too
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Thu, 30 Oct 2008 14:03:43 +0300
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, alessandro.zummo@towertech.it, tsbogend@alpha.franken.de
In-reply-to: <200810292121.m9TLLYjd019910@imap1.linux-foundation.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200810292121.m9TLLYjd019910@imap1.linux-foundation.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.17 (Windows/20080914)
Hello.

akpm@linux-foundation.org wrote:

From: Andrew Morton <akpm@linux-foundation.org>

drivers/rtc/rtc-m48t35.c: In function 'm48t35_read_time':
drivers/rtc/rtc-m48t35.c:59: error: implicit declaration of function 'readb'
drivers/rtc/rtc-m48t35.c:60: error: implicit declaration of function 'writeb'
drivers/rtc/rtc-m48t35.c: In function 'm48t35_probe':
drivers/rtc/rtc-m48t35.c:168: error: implicit declaration of function 'ioremap'
drivers/rtc/rtc-m48t35.c:168: warning: assignment makes pointer from integer 
without a cast
drivers/rtc/rtc-m48t35.c:188: error: implicit declaration of function 'iounmap'

  I wonder how that's possible with the correct #include's?

Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Alessandro Zummo <alessandro.zummo@towertech.it>
Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
[...]
diff -puN drivers/rtc/Kconfig~drivers-rtc-rtc-m48t35c-is-borked-too 
drivers/rtc/Kconfig
--- a/drivers/rtc/Kconfig~drivers-rtc-rtc-m48t35c-is-borked-too
+++ a/drivers/rtc/Kconfig
@@ -432,6 +432,7 @@ config RTC_DRV_M48T86
config RTC_DRV_M48T35
        tristate "ST M48T35"
+       depends on MIPS

  It shouldn't really be MIPS specific -- the patch seems wrong.

WBR, Sergei



<Prev in Thread] Current Thread [Next in Thread>