linux-mips
[Top] [All Lists]

Re: [PATCH 11/36] MIPSR2 ebase isn't just CAC_BASE

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 11/36] MIPSR2 ebase isn't just CAC_BASE
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Tue, 28 Oct 2008 16:05:34 +0000 (GMT)
Cc: David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org, Tomaso Paoletti <tpaoletti@caviumnetworks.com>
In-reply-to: <20081028095655.GB18610@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1225152181-3221-2-git-send-email-ddaney@caviumnetworks.com> <1225152181-3221-3-git-send-email-ddaney@caviumnetworks.com> <1225152181-3221-4-git-send-email-ddaney@caviumnetworks.com> <1225152181-3221-5-git-send-email-ddaney@caviumnetworks.com> <1225152181-3221-6-git-send-email-ddaney@caviumnetworks.com> <1225152181-3221-7-git-send-email-ddaney@caviumnetworks.com> <1225152181-3221-8-git-send-email-ddaney@caviumnetworks.com> <1225152181-3221-9-git-send-email-ddaney@caviumnetworks.com> <1225152181-3221-10-git-send-email-ddaney@caviumnetworks.com> <1225152181-3221-11-git-send-email-ddaney@caviumnetworks.com> <20081028095655.GB18610@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 1.10 (LFD 962 2008-03-14)
On Tue, 28 Oct 2008, Ralf Baechle wrote:

> Another thing I noticed is that we don't use write_c0_ebase(), so the
> firmware better setup this correctly or we crash and burn.  We better
> should initialize that right ...

 Well, your version still does not do it...

> So below my version which solves the first mentioned problem.  Just like
> the bitops patch I posted earlier today this patch has become entirely
> unrelated to the rest of the series so can applied before or after the
> rest of the series.

 Anyway this is much better than the original proposal indeed, thanks.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>