| To: | linux-mips@linux-mips.org |
|---|---|
| Subject: | [PATCH] tx4938ide: Avoid underflow on calculation of a wait cycle |
| From: | Atsushi Nemoto <anemo@mba.ocn.ne.jp> |
| Date: | Tue, 28 Oct 2008 22:09:04 +0900 (JST) |
| Cc: | linux-ide@vger.kernel.org, Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>, ralf@linux-mips.org, sshtylyov@ru.mvista.com |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| Sender: | linux-mips-bounce@linux-mips.org |
Make 'wt' variable signed while it can be negative during calculation.
Suggested-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
drivers/ide/tx4938ide.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/ide/tx4938ide.c b/drivers/ide/tx4938ide.c
index 796289c..9120063 100644
--- a/drivers/ide/tx4938ide.c
+++ b/drivers/ide/tx4938ide.c
@@ -26,12 +26,13 @@ static void tx4938ide_tune_ebusc(unsigned int ebus_ch,
unsigned int sp = (cr >> 4) & 3;
unsigned int clock = gbus_clock / (4 - sp);
unsigned int cycle = 1000000000 / clock;
- unsigned int wt, shwt;
+ unsigned int shwt;
+ int wt;
/* Minimum DIOx- active time */
wt = DIV_ROUND_UP(t->act8b, cycle) - 2;
/* IORDY setup time: 35ns */
- wt = max(wt, DIV_ROUND_UP(35, cycle));
+ wt = max_t(int, wt, DIV_ROUND_UP(35, cycle));
/* actual wait-cycle is max(wt & ~1, 1) */
if (wt > 2 && (wt & 1))
wt++;
--
1.5.6.3
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [rtc-linux] Re: [RFC PATCH] Au1xxx on-chip counter-as-RTC driver, Alessandro Zummo |
|---|---|
| Next by Date: | [PATCH] tc35815: Define more Rx status bits, Atsushi Nemoto |
| Previous by Thread: | [PATCH 00/36] Add Cavium OCTEON processor support (v2)., David Daney |
| Next by Thread: | Re: [PATCH] tx4938ide: Avoid underflow on calculation of a wait cycle, Bartlomiej Zolnierkiewicz |
| Indexes: | [Date] [Thread] [Top] [All Lists] |