linux-mips
[Top] [All Lists]

Re: [rtc-linux] Re: [RFC PATCH] Au1xxx on-chip counter-as-RTC driver

To: rtc-linux@googlegroups.com, Linux-MIPS <linux-mips@linux-mips.org>, Kevin Hickey <khickey@rmicorp.com>, Manuel Lauss <mano@roarinelk.homelinux.net>
Subject: Re: [rtc-linux] Re: [RFC PATCH] Au1xxx on-chip counter-as-RTC driver
From: Alessandro Zummo <alessandro.zummo@towertech.it>
Date: Tue, 28 Oct 2008 11:59:27 +0100
In-reply-to: <20081028105220.GA1235@roarinelk.homelinux.net>
Organization: Tower Technologies
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080809161402.15e24b2e@flagship.roarinelk.net> <20081021203815.1a0a246d@i1501.lan.towertech.it> <20081022073114.GA11169@roarinelk.homelinux.net> <20081028111704.2feb3b53@i1501.lan.towertech.it> <20081028105220.GA1235@roarinelk.homelinux.net>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 28 Oct 2008 11:52:20 +0100
Manuel Lauss <mano@roarinelk.homelinux.net> wrote:

> >  I'd need some feedback from linux-mips, otherwise
> >  I can only Sign-off for the entries in drivers/rtc .  
> 
> I stripped the alchemy board parts away from the patch; they can go in
> through the mips tree at a later time.

 ok.

> >  Btw why are you using a lock? the rtc class core
> >  already provides his own lock for the ops calls.  
> 
> Didn't know that; I mostly looked at rtc-sh.c for guidance which also
> uses its own locks.

 I think it's due to the interrupt handling in rtc-sh.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it


<Prev in Thread] Current Thread [Next in Thread>