| To: | Ralf Baechle <ralf@linux-mips.org> |
|---|---|
| Subject: | Re: [PATCH 02/36] Add Cavium OCTEON files to arch/mips/include/asm/mach-cavium-octeon |
| From: | Sergei Shtylyov <sshtylyov@ru.mvista.com> |
| Date: | Tue, 28 Oct 2008 13:36:10 +0300 |
| Cc: | David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org, Tomaso Paoletti <tpaoletti@caviumnetworks.com>, Paul Gortmaker <Paul.Gortmaker@windriver.com> |
| In-reply-to: | <20081028075733.GB20858@linux-mips.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <490655B6.4030406@caviumnetworks.com> <1225152181-3221-1-git-send-email-ddaney@caviumnetworks.com> <1225152181-3221-2-git-send-email-ddaney@caviumnetworks.com> <20081028075733.GB20858@linux-mips.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Thunderbird 2.0.0.17 (Windows/20080914) |
Hello. Ralf Baechle wrote: +/** + * Write a 32bit value to the Octeon NPI register space + * + * @param address Address to write to + * @param val Value to write + */Linux coding style - comments are: /* * blah frobnicate zumbitso */ sed is your friend to fix this. This is kernel-doc style but looking wrong anyway. It should be: /** * octeon_npi_write32 - write a 32bit value to the Octeon NPI register space * * @address: address to write to * @val : value to write */ WBR, Sergei |
| Previous by Date: | Re: [rtc-linux] Re: [RFC PATCH] Au1xxx on-chip counter-as-RTC driver, Alessandro Zummo |
|---|---|
| Next by Date: | Re: [rtc-linux] Re: [RFC PATCH] Au1xxx on-chip counter-as-RTC driver, Manuel Lauss |
| Previous by Thread: | Re: [PATCH 02/36] Add Cavium OCTEON files to arch/mips/include/asm/mach-cavium-octeon, Ralf Baechle |
| Next by Thread: | Re: [PATCH 02/36] Add Cavium OCTEON files to arch/mips/include/asm/mach-cavium-octeon, Maciej W. Rozycki |
| Indexes: | [Date] [Thread] [Top] [All Lists] |