linux-mips
[Top] [All Lists]

Re: [PATCH][MIPS] fix kgdb build error

To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Subject: Re: [PATCH][MIPS] fix kgdb build error
From: Ralf Baechle <ralf@linux-mips.org>
Date: Sat, 25 Oct 2008 19:20:49 +0100
Cc: linux-mips <linux-mips@linux-mips.org>, David Daney <ddaney@caviumnetworks.com>
In-reply-to: <20081025173035.6e05f8dc.yoichi_yuasa@tripeaks.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20081025001725.7ac18a1b.yoichi_yuasa@tripeaks.co.jp> <20081024164241.GB21892@linux-mips.org> <20081025173035.6e05f8dc.yoichi_yuasa@tripeaks.co.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Oct 25, 2008 at 05:30:35PM +0900, Yoichi Yuasa wrote:

> > <asm/ptrace.h> is exported to userland so we can't include these types.
> > Basically <linux/types.h> or <stdint.h> are polluting the namespace.  So
> > either we use some __* type and include only those or we get entirely
> > rid of typedef'ed types - as in the patch that you've posted while I was
> > writing this.
> 
> Thank you for your comment.
> KGDB still has a problem. This is kernel part in ptrace.h.
> 
> ---

Note that git will drop ALL comments below the "---" line which is not
what you want here ...

> Fix KGDB build error
> 
> In file included from include/linux/ptrace.h:49,
>                  from arch/mips/kernel/kgdb.c:25:
> /home/yuasa/src/linux/test/mips/linux/arch/mips/include/asm/ptrace.h:123: 
> error: expected declaration specifiers or '...' before '__s64'
> /home/yuasa/src/linux/test/mips/linux/arch/mips/include/asm/ptrace.h:124: 
> error: expected declaration specifiers or '...' before '__s64'
> /home/yuasa/src/linux/test/mips/linux/arch/mips/include/asm/ptrace.h:126: 
> error: expected declaration specifiers or '...' before '__u32'
> /home/yuasa/src/linux/test/mips/linux/arch/mips/include/asm/ptrace.h:127: 
> error: expected declaration specifiers or '...' before '__u32'
> make[1]: *** [arch/mips/kernel/kgdb.o] Error 1
> 
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>

Applied.  Thanks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>