linux-mips
[Top] [All Lists]

Re: [PATCH] [MIPS] sgi_btns: add license specification

To: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH] [MIPS] sgi_btns: add license specification
From: Ralf Baechle <ralf@linux-mips.org>
Date: Sat, 25 Oct 2008 15:45:02 +0100
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <1224888417-26494-2-git-send-email-dmitri.vorobiev@movial.fi>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1224888417-26494-1-git-send-email-dmitri.vorobiev@movial.fi> <1224888417-26494-2-git-send-email-dmitri.vorobiev@movial.fi>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Oct 25, 2008 at 01:46:57AM +0300, Dmitri Vorobiev wrote:

> The SGI Volume Button interface driver uses GPL-only symbols
> platform_driver_unregister and platform_driver_register, but
> lacks license specification. Thus, when compiled as a module,
> this driver cannot be installed. This patch fixes this by
> adding the MODULE_LICENSE() specification.
> 
> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>

Patch is correct - but it stumped my nose at another bug.

A platform driver is supposed to be safe if loaded into a kernel for another
machine.  With the #ifdef'ed sections of this driver, a crash would be
likely if the module built for IP22 would be loaded into an IP32 kernel or
vice versa.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>