Re: [PATCH] [MIPS] sgi_btns: add license specification

[Ralf Baechle <ralf@linux-mips.org>]

On Sat, Oct 25, 2008 at 01:46:57AM +0300, Dmitri Vorobiev wrote:

> The SGI Volume Button interface driver uses GPL-only symbols
> platform_driver_unregister and platform_driver_register, but
> lacks license specification. Thus, when compiled as a module,
> this driver cannot be installed. This patch fixes this by
> adding the MODULE_LICENSE() specification.
> 
> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>

Patch is correct - but it stumped my nose at another bug.

A platform driver is supposed to be safe if loaded into a kernel for another
machine.  With the #ifdef'ed sections of this driver, a crash would be
likely if the module built for IP22 would be loaded into an IP32 kernel or
vice versa.

  Ralf