linux-mips
[Top] [All Lists]

Re: [PATCH] [MIPS] IP22: Small cleanups

To: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Subject: Re: [PATCH] [MIPS] IP22: Small cleanups
From: Ralf Baechle <ralf@linux-mips.org>
Date: Sat, 25 Oct 2008 15:27:44 +0100
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <1224888417-26494-1-git-send-email-dmitri.vorobiev@movial.fi>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1224888417-26494-1-git-send-email-dmitri.vorobiev@movial.fi>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Oct 25, 2008 at 01:46:56AM +0300, Dmitri Vorobiev wrote:

> diff --git a/arch/mips/sgi-ip22/ip22-int.c b/arch/mips/sgi-ip22/ip22-int.c
> index f6d9bf4..5b9b4f3 100644
> --- a/arch/mips/sgi-ip22/ip22-int.c
> +++ b/arch/mips/sgi-ip22/ip22-int.c
> @@ -16,6 +16,7 @@
>  #include <linux/sched.h>
>  #include <linux/interrupt.h>
>  #include <linux/irq.h>
> +#include <linux/time.h>
>  
>  #include <asm/mipsregs.h>
>  #include <asm/addrspace.h>
> @@ -23,7 +24,6 @@
>  #include <asm/sgi/ioc.h>
>  #include <asm/sgi/hpc3.h>
>  #include <asm/sgi/ip22.h>
> -#include <asm/time.h>

<linux/time.h> does not include <asm/time.h>.  This sort of stuff happens
if you believe checkpatch.pl.  You only got away because the header isn't
needed anyway.  I'll apply the patch with this bit dropped.

  Ralf

PS: Suspicion breeds confidence.  At least in case of checkpatch ;-)

<Prev in Thread] Current Thread [Next in Thread>