linux-mips
[Top] [All Lists]

Re: [PATCH] defined a macro for lemote 2e box IO base

To: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH] defined a macro for lemote 2e box IO base
From: Zhang Le <r0bertz@gentoo.org>
Date: Sat, 25 Oct 2008 15:31:54 +0800
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <alpine.LFD.1.10.0810242119430.31223@ftp.linux-mips.org>
Mail-followup-to: "Maciej W. Rozycki" <macro@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1224722939-18557-1-git-send-email-r0bertz@gentoo.org> <20081022202812.GB10625@linux-mips.org> <20081024072745.GA14652@adriano.hkcable.com.hk> <alpine.LFD.1.10.0810242119430.31223@ftp.linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.16 (2007-06-09)
On 21:24 Fri 24 Oct     , Maciej W. Rozycki wrote:
> On Fri, 24 Oct 2008, Zhang Le wrote:
> 
> > Thanks for the comment.
> > I have checked how other platforms handle this problem.
> > Many have used CKSEG1ADDR.
> 
>  Please note long-term we want CKSEG1ADDR() to go away from board/platform 
> code and possibly only keep it for some generic use if at all.  Have you 
> considered using ioremap()?  With a literal physical address it should get 
> optimised to the same code as the use of CKSEG1ADDR() produces, yet keep 
> the source portable and in line with the rest of the kernel.

Thank you!
I will make a new patch.

Zhang, Le

<Prev in Thread] Current Thread [Next in Thread>