linux-mips
[Top] [All Lists]

Re: [PATCH] defined a macro for lemote 2e box IO base

To: Zhang Le <r0bertz@gentoo.org>
Subject: Re: [PATCH] defined a macro for lemote 2e box IO base
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Fri, 24 Oct 2008 21:24:05 +0100 (BST)
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <20081024072745.GA14652@adriano.hkcable.com.hk>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1224722939-18557-1-git-send-email-r0bertz@gentoo.org> <20081022202812.GB10625@linux-mips.org> <20081024072745.GA14652@adriano.hkcable.com.hk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 1.10 (LFD 962 2008-03-14)
On Fri, 24 Oct 2008, Zhang Le wrote:

> Thanks for the comment.
> I have checked how other platforms handle this problem.
> Many have used CKSEG1ADDR.

 Please note long-term we want CKSEG1ADDR() to go away from board/platform 
code and possibly only keep it for some generic use if at all.  Have you 
considered using ioremap()?  With a literal physical address it should get 
optimised to the same code as the use of CKSEG1ADDR() produces, yet keep 
the source portable and in line with the rest of the kernel.  I try to 
remove references to CKSEG1ADDR() as I come across them myself too.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>