linux-mips
[Top] [All Lists]

Re: [PATCH 11/37] Cavium OCTEON: ebase isn't just CAC_BASE

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH 11/37] Cavium OCTEON: ebase isn't just CAC_BASE
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Fri, 24 Oct 2008 20:56:52 +0100 (BST)
Cc: linux-mips@linux-mips.org, Tomaso Paoletti <tpaoletti@caviumnetworks.com>
In-reply-to: <1224809821-5532-12-git-send-email-ddaney@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1224809821-5532-1-git-send-email-ddaney@caviumnetworks.com> <1224809821-5532-12-git-send-email-ddaney@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 1.10 (LFD 962 2008-03-14)
On Thu, 23 Oct 2008, ddaney@caviumnetworks.com wrote:

> From: David Daney <ddaney@caviumnetworks.com>
> 
> On Cavium, the ebase isn't just CAC_BASE, but also the part of
> read_c0_ebase() too.

 How is that unique to CONFIG_CPU_CAVIUM_OCTEON?  That's a general feature 
of the MIPS revision 2 architecture, so please make it right from the 
beginning.  You'll avoid an ugly #ifdef this way too.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>