linux-mips
[Top] [All Lists]

Re: [PATCH][MIPS] fix kgdb build error

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH][MIPS] fix kgdb build error
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 24 Oct 2008 18:09:50 +0100
Cc: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>, linux-mips <linux-mips@linux-mips.org>
In-reply-to: <4901F851.8010103@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20081025001725.7ac18a1b.yoichi_yuasa@tripeaks.co.jp> <4901F851.8010103@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Oct 24, 2008 at 09:31:13AM -0700, David Daney wrote:

> Yoichi Yuasa wrote:
>> ptrace.h needs #include <linux/types.h>
>>
> [...]
>
> Can you try this completely untested patch instead?
>
> If it works, I will give it a more thorough test over the next few
> weeks.

This looks correct, I think.

Though I was wondering about two special cases:

  o 32-bit debugger debugging a 64-bit process
  o 64-bit debugger debugging a 32-bit process

The unions make we wonder if that case was considered ...

Anyway, your patch certainly solves Yoichi's original bug so I'll apply it.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>