linux-mips
[Top] [All Lists]

Re: [PATCH] ide: Add tx4938ide driver (v2)

To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH] ide: Add tx4938ide driver (v2)
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Fri, 24 Oct 2008 15:12:15 +0400
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, linux-mips@linux-mips.org, linux-ide@vger.kernel.org, ralf@linux-mips.org
In-reply-to: <200810232247.05686.bzolnier@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20081023.012013.52129771.anemo@mba.ocn.ne.jp> <200810232247.05686.bzolnier@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.17 (Windows/20080914)
Hello.

Bartlomiej Zolnierkiewicz wrote:

This is the driver for the Toshiba TX4938 SoC EBUS controller ATA mode.
It has custom set_pio_mode and some hacks for big endian.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

I applied it so please address issues left (if any) with incremental patches.

I'm not sure there was really a need to haste it into -rc1 (if you could push it to Linus later anyway)... I've realized that I have a question to Atsushi on why he chose the same way of implemnting the register accesses as on TX4939 despite TX4938 IDE is not really a SoC but a board level device (so probable should be using the normal, not the "raw" I/O accessors)...

MBR, Sergei



<Prev in Thread] Current Thread [Next in Thread>