Re: [PATCH] ide: Add tx4938ide driver (v2)

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Bartlomiej Zolnierkiewicz wrote:

> > This is the driver for the Toshiba TX4938 SoC EBUS controller ATA mode.
> > It has custom set_pio_mode and some hacks for big endian.
> >
> > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> >     
> I applied it so please address issues left (if any) with incremental patches.
>   
  I'm not sure there was really a need to haste it into -rc1 (if you 
could push it to Linus later anyway)...
  I've realized that I have a question to Atsushi on why he chose the 
same way of implemnting the register accesses as on TX4939 despite 
TX4938 IDE is not really a SoC but a board level device (so probable 
should be using the normal, not the "raw" I/O accessors)...
MBR, Sergei