linux-mips
[Top] [All Lists]

Re: [PATCH] ide: Add tx4939ide driver (v5)

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH] ide: Add tx4939ide driver (v5)
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: Thu, 23 Oct 2008 22:00:35 +0200
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, linux-mips@linux-mips.org, linux-ide@vger.kernel.org, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=vc4kjszoteVA+zP1tfhY8wamT+VGUdl0k6/SLiE3vrU=; b=b6yVsmOLxh1VwW0EPUvW8v1agDwr2J6xGrX037CE9OrxFN/47OwTunTle5ZbOQDoZ1 uH+oiVDsOMKFFOLpJKBBaFFnYCr9W070zblbFrKKgrpnkHquVifZmukpRaLg9EOvrdtP EycUo+BfOz304D36xrQyocX8faWwsTlwzLPAY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=IKZmFVvIlqgxnbUReJTYs7LeQsCQKKeEodGGt0LYj+EiL7Q0qLt1RoYXiAw1E6HyIq 7c37PHrG449FBxRdg4whcQZz7kKTvjbikmUvr++Dd/GFKqZcxthj18uYGtkKXkQhSzKf 98vvMehn+zd4MMfyqYolIMgr/zDejoyG1/bLg=
In-reply-to: <48FDFE89.5030501@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20081020.212701.59651580.anemo@mba.ocn.ne.jp> <48FDFE89.5030501@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.10
On Tuesday 21 October 2008, Sergei Shtylyov wrote:

> > +           pr_err("%s: Error interrupt %#x (%s%s%s )\n",
> > +                  hwif->name, ctl,
> > +                  (ctl & TX4939IDE_INT_ADDRERR) ?
> > +                  " Address-Error" : "",
> > +                  (ctl & TX4939IDE_INT_DEVTIMING) ?
> > +                  " DEV-Timing" : "",
> > +                  (ctl & TX4939IDE_INT_BUSERR) ?
> 
>     Parens around & shouldn't be needed...

While the above remark is certainly correct we usually leave such parens
to ease the reading of the code and to match the other parts of the kernel...

[ No need to change it again, just a minor note... ]

<Prev in Thread] Current Thread [Next in Thread>