Re: [PATCH] defined a macro for lemote 2e box IO base

linux-mips

Re: [PATCH] defined a macro for lemote 2e box IO base

To:	Zhang Le <r0bertz@gentoo.org>
Subject:	Re: [PATCH] defined a macro for lemote 2e box IO base
From:	Ralf Baechle <ralf@linux-mips.org>
Date:	Wed, 22 Oct 2008 21:28:13 +0100
Cc:	linux-mips@linux-mips.org
In-reply-to:	<1224722939-18557-1-git-send-email-r0bertz@gentoo.org>
Original-recipient:	rfc822;linux-mips@linux-mips.org
References:	<1224722939-18557-1-git-send-email-r0bertz@gentoo.org>
Sender:	linux-mips-bounce@linux-mips.org
User-agent:	Mutt/1.5.18 (2008-05-17)

On Thu, Oct 23, 2008 at 12:48:58AM +0000, Zhang Le wrote:

> +#ifdef CONFIG_64BIT
> +#define LEMOTE_IO_PORT_BASE 0xffffffffbfd00000
> +#else
> +#define LEMOTE_IO_PORT_BASE 0xbfd00000
> +#endif

This sort of #ifdefery is one of the reasons why it's better to define
physical addresses of devices, not virtual addresses in header files.

  Ralf

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] defined a macro for lemote 2e box IO base, Zhang Le [PATCH] added io_map_base to pci_controller on Lemote 2e box, Zhang Le Re: [PATCH] added io_map_base to pci_controller on Lemote 2e box, Zhang Le Re: [PATCH] defined a macro for lemote 2e box IO base, Thiemo Seufer Re: [PATCH] defined a macro for lemote 2e box IO base, Ralf Baechle <= Re: [PATCH] defined a macro for lemote 2e box IO base, Zhang Le Re: [PATCH] defined a macro for lemote 2e box IO base, Maciej W. Rozycki Re: [PATCH] defined a macro for lemote 2e box IO base, Ralf Baechle Re: [PATCH] defined a macro for lemote 2e box IO base, Zhang Le

Previous by Date:	Re: [PATCH] defined a macro for lemote 2e box IO base, Thiemo Seufer
Next by Date:	AR7 MIPS development tools, Arao H. Filho
Previous by Thread:	Re: [PATCH] defined a macro for lemote 2e box IO base, Thiemo Seufer
Next by Thread:	Re: [PATCH] defined a macro for lemote 2e box IO base, Zhang Le
Indexes:	[Date] [Thread] [Top] [All Lists]