Re: [PATCH] TXx9: Add TX4938 ATA support

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Atsushi Nemoto wrote:

> > > +       struct tx4938ide_platform_info pdata = {
> > > +               .ioport_shift = shift,
> > > +               .gbus_clock = tune ? txx9_gbus_clock : 0,
> >    Any reason not to supply the GBUS clock?
> The EBUS channel might be used for both ATA and ISA or other local bus
> devices.  In that case, the board setup code should initialize best
> timings for all devices and the IDE driver should not overrite it.
   Ah, I forgot about the ATA address space being appeandage to ISA address 
space on TX4939...
> >    I'm afraid you can't just early return from the set_pio_mode() method...
> Do you mean I should use IDE_HFLAG_NO_SET_MODE instead of just
> returning from set_pio_mode?
   No, that's for the smart RAID controllers that program the transfer modes 
themselves. In your case, hwif->port_ops->set_pio_mode() must be NULL -- if 
you're not going to allow the mode programming, that is.
MBR, Sergei