linux-mips
[Top] [All Lists]

Re: [PATCH] ide: Add tx4939ide driver (v4)

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] ide: Add tx4939ide driver (v4)
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: Fri, 17 Oct 2008 18:46:34 +0200
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, linux-mips@linux-mips.org, linux-ide@vger.kernel.org, sshtylyov@ru.mvista.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version :content-disposition:message-id:content-type :content-transfer-encoding; bh=uiWn5KFpmCKKG0qXd/vQHVhYyNUEYWCOKy3xGOi3nHU=; b=q+gTYAjMfAlGGe/0DTO4kMm6MuhW96XtV+jr9p8y7/EnGoM61CIBn5B1yLk2701zut dRsmVfCKzkOIT1Pwb8oFlMDgiTgmADIKKKZxzZOAqZOFgKtCZcK/GTdFLo6/W7f/fIGa AtSTqqAcaM1R8WypFdGVtblsjzL16KLZ9yu1g=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-disposition:message-id:content-type :content-transfer-encoding; b=N4d34wOOjd9guHy62GMmdaVTtuonDVYoHtIEDrweg2wu8BfcpDie77kA84Uedt0+X3 SZTachWEX0lZfZnXwvmhWlXfXBpHkIJ3IfaylbbMauYKNiB4/pMfWHN4BYQytJXYfMTK l46YZUKAIL+DBpGbfwxdMC6rFwqo26k3hNHYg=
In-reply-to: <20081017141310.GA14999@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20081017.230825.95059872.anemo@mba.ocn.ne.jp> <20081017141310.GA14999@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.10
On Friday 17 October 2008, Ralf Baechle wrote:
> On Fri, Oct 17, 2008 at 11:08:25PM +0900, Atsushi Nemoto wrote:
> 
> > This is the driver for the Toshiba TX4939 SoC ATA controller.
> > 
> > This controller has standard ATA taskfile registers and DMA
> > command/status registers, but the register layout is swapped on big
> > endian.  There are some other endian issue and some special registers
> > which requires many custom dma_ops/tp_ops routines and build_dmatable.
> > 
> > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> > ---
> > This patch is against current linux-mips tree.
> > 
> > Changes since v3:
> > * more consistent symbol naming
> > * handle only DMA mode in set_dma_mode
> > * rename tx4939ide_read_and_clear_dma_status to tx4939ide_clear_dma_status
> > * use standard ide_read_sff_dma_status in LE mode
> > * remove CS5530 workaround from tx4939ide_build_dmatable
> > * use ide_host_alloc/ide_host_register instead of ide_host_alloc
> > * fold tx4939ide_insw_swap into tx4939ide_input_data_swap
> > * more informative printk
> > * whitespace cleanups and spelling fixes
> > 
> >  drivers/ide/Kconfig          |    6 +
> >  drivers/ide/mips/Makefile    |    1 +
> >  drivers/ide/mips/tx4939ide.c |  755 
> > ++++++++++++++++++++++++++++++++++++++++++
> 
> Btw, I don't think architecture specific subdirectories in subsystems are
> generally usefull.  Just as in this example this IDE controller happens
> only to be in use on a particular MIPS-based SOC but there is nothing
> really architecture specific in most such devices.

I fully agree with you.

I was going to remove arch/bus specific subdirs in .29 but since the change
should be really straightforward and we're ahead of the merge schedule for
.28 I think we may as well do it now...

I'll prepare corresponding IDE git pull request next week.

Thanks,
Bart

<Prev in Thread] Current Thread [Next in Thread>