linux-mips
[Top] [All Lists]

Re: [PATCH] ide: Add tx4939ide driver (v4)

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] ide: Add tx4939ide driver (v4)
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 17 Oct 2008 15:13:10 +0100
Cc: linux-mips@linux-mips.org, linux-ide@vger.kernel.org, Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>, sshtylyov@ru.mvista.com
In-reply-to: <20081017.230825.95059872.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20081017.230825.95059872.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Oct 17, 2008 at 11:08:25PM +0900, Atsushi Nemoto wrote:

> This is the driver for the Toshiba TX4939 SoC ATA controller.
> 
> This controller has standard ATA taskfile registers and DMA
> command/status registers, but the register layout is swapped on big
> endian.  There are some other endian issue and some special registers
> which requires many custom dma_ops/tp_ops routines and build_dmatable.
> 
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> This patch is against current linux-mips tree.
> 
> Changes since v3:
> * more consistent symbol naming
> * handle only DMA mode in set_dma_mode
> * rename tx4939ide_read_and_clear_dma_status to tx4939ide_clear_dma_status
> * use standard ide_read_sff_dma_status in LE mode
> * remove CS5530 workaround from tx4939ide_build_dmatable
> * use ide_host_alloc/ide_host_register instead of ide_host_alloc
> * fold tx4939ide_insw_swap into tx4939ide_input_data_swap
> * more informative printk
> * whitespace cleanups and spelling fixes
> 
>  drivers/ide/Kconfig          |    6 +
>  drivers/ide/mips/Makefile    |    1 +
>  drivers/ide/mips/tx4939ide.c |  755 
> ++++++++++++++++++++++++++++++++++++++++++

Btw, I don't think architecture specific subdirectories in subsystems are
generally usefull.  Just as in this example this IDE controller happens
only to be in use on a particular MIPS-based SOC but there is nothing
really architecture specific in most such devices.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>