| To: | sshtylyov@ru.mvista.com |
|---|---|
| Subject: | Re: [PATCH] ide: Add tx4939ide driver (v3) |
| From: | Atsushi Nemoto <anemo@mba.ocn.ne.jp> |
| Date: | Fri, 17 Oct 2008 02:29:10 +0900 (JST) |
| Cc: | linux-mips@linux-mips.org, linux-ide@vger.kernel.org, bzolnier@gmail.com, ralf@linux-mips.org |
| In-reply-to: | <48F7787B.2060807@ru.mvista.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <48F7391D.8050109@ru.mvista.com> <20081017.013101.128619577.anemo@mba.ocn.ne.jp> <48F7787B.2060807@ru.mvista.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Thu, 16 Oct 2008 21:23:07 +0400, Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote: > >>>+ if ((dma_stat & 7) == 0 && > >>>+ (ctl & (TX4939IDE_INT_XFEREND | TX4939IDE_INT_HOST)) == > >>>+ (TX4939IDE_INT_XFEREND | TX4939IDE_INT_HOST)) > >> > >> Parens around & and | are hardly needed... > > > You mean more parens are needed? > > I mean less. :-) Well, I think all above parens are required. '&' and '|' are weaker than '==', no? --- Atsushi Nemoto |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] ide: Add tx4939ide driver (v3), Sergei Shtylyov |
|---|---|
| Next by Date: | [PATCH] Fix debugfs_create_*'s error checking method for mips/kernel/, Zhaolei |
| Previous by Thread: | Re: [PATCH] ide: Add tx4939ide driver (v3), Sergei Shtylyov |
| Next by Thread: | Bogus code in linux-queue commit 381ef5828990102b098aeb0a1f6958efd2e99733, David Daney |
| Indexes: | [Date] [Thread] [Top] [All Lists] |