Re: [PATCH] ide: Add tx4939ide driver (v3)

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Atsushi Nemoto wrote:

> > > This is the driver for the Toshiba TX4939 SoC ATA controller.
> >   Mostly ACK but there's still a few minor nits...
> Welcome back!
   Indeed, it turned out to be hard to drown in the Dead see. :-)

>  I will address all of your points except for followings.
> > > +                       xcount = bcount & 0xffff;
> > > +                       if (xcount == 0x0000) {
> > >  
> >   Hm, I'm not sure this is necessary here... although I didn't see an 
> > explicit mention that zero count means 64 KB in the datasheet -- which 
> > it must mean if the BMIDE spec. was followed).
> > In ide-dma.c this check was added because of CS5530's brain damage...
> Hmm, if I could test this case easily I will drop this.  Otherwise I
> will keep it as is for future investigation.
   OK.

> > > +       if ((dma_stat & 7) == 0 &&
> > > +           (ctl & (TX4939IDE_INT_XFEREND | TX4939IDE_INT_HOST)) ==
> > > +           (TX4939IDE_INT_XFEREND | TX4939IDE_INT_HOST))
> >   Parens around & and | are hardly needed...
> You mean more parens are needed?
   I mean less. :-)

> ---
> Atsushi Nemoto
MBR, Sergei