linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Rewrite cpu_to_name so it has one statement per line.

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: Rewrite cpu_to_name so it has one statement per line.
From: David Daney <ddaney@caviumnetworks.com>
Date: Tue, 14 Oct 2008 09:14:56 -0700
Cc: linux-mips@linux-mips.org, "Paoletti, Tomaso" <Tomaso.Paoletti@caviumnetworks.com>
In-reply-to: <20081014090109.GB30880@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <48F38CBE.20303@caviumnetworks.com> <20081014090109.GB30880@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.16 (X11/20080723)
Ralf Baechle wrote:
On Mon, Oct 13, 2008 at 11:00:30AM -0700, David Daney wrote:

Rewrite cpu_to_name so it has one statement per line.

Future changes can now pass checkpatch.pl

It's been one of those changes where I found the Linux coding style in my
opinion at least, not to be optimal.  My plan was to rewrite it like below
incomplete patch for ages.  What do you think?

  Ralf

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

diff --git a/arch/mips/include/asm/cpu-info.h b/arch/mips/include/asm/cpu-info.h
index 744cd8f..6d0f891 100644
--- a/arch/mips/include/asm/cpu-info.h
+++ b/arch/mips/include/asm/cpu-info.h
@@ -75,6 +75,7 @@ struct cpuinfo_mips {
        unsigned int            watch_reg_use_cnt; /* Usable by ptrace */
 #define NUM_WATCH_REGS 4
        u16                     watch_reg_masks[NUM_WATCH_REGS];
+       const char              *name;
 } __attribute__((aligned(SMP_CACHE_BYTES)));

It increases the size of the cpuinfo_mips structure by sizeof(char *)
for data that is only ever used in /proc/cpuinfo, also it goes against
my sense of data normalization.  So I think the current method of
looking it up on demand is fine.

I am not enamored with my patch as it doubles the number of lines in
the function.  So we will defer to you and follow which ever style you
decide is best.

David Daney

<Prev in Thread] Current Thread [Next in Thread>