linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] show_cpuinfo prints the name of the calling CPU, which i

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH 2/2] show_cpuinfo prints the name of the calling CPU, which i think is wrong.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 14 Oct 2008 09:36:14 +0100
Cc: Johannes Dickgreber <tanzy@gmx.de>, linux-mips@linux-mips.org
In-reply-to: <48F3DAF9.5000603@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1223919381-24521-1-git-send-email-tanzy@gmx.de> <20081013222146.GD8145@linux-mips.org> <48F3DAF9.5000603@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Oct 13, 2008 at 04:34:17PM -0700, David Daney wrote:

> The patch is required on SMP systems as without it you get:
>
> BUG: using smp_processor_id() in preemptible [00000000] code: cat/687
> caller is show_cpuinfo+0xc4/0x500
> Call Trace:
> [<ffffffff8111f4c8>] dump_stack+0x8/0x38
> [<ffffffff812c235c>] debug_smp_processor_id+0xec/0x100
> [<ffffffff8112de64>] show_cpuinfo+0xc4/0x500
> [<ffffffff811d4128>] seq_read+0x2f8/0x420
> [<ffffffff811fb658>] proc_reg_read+0x90/0xd8
> [<ffffffff811b05ec>] vfs_read+0xbc/0x160
> [<ffffffff811b0a88>] sys_read+0x50/0x98
> [<ffffffff81129224>] handle_sysn32+0x44/0x84

Uh indeed, makes sense ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>