linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] show_cpuinfo prints the name of the calling CPU, which i

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 2/2] show_cpuinfo prints the name of the calling CPU, which i think is wrong.
From: David Daney <ddaney@caviumnetworks.com>
Date: Mon, 13 Oct 2008 16:34:17 -0700
Cc: Johannes Dickgreber <tanzy@gmx.de>, linux-mips@linux-mips.org
In-reply-to: <20081013222146.GD8145@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1223919381-24521-1-git-send-email-tanzy@gmx.de> <20081013222146.GD8145@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.16 (X11/20080723)
Ralf Baechle wrote:
On Mon, Oct 13, 2008 at 07:36:21PM +0200, Johannes Dickgreber wrote:

Cc: linux-mips@linux-mips.org
Subject: [PATCH 2/2] show_cpuinfo prints the name of the calling CPU, which i
        think is wrong.

Patch is correct and so I applied it.  Not a big issue though.  There is
only one system supported currently that supports a mix of different
processor types (IP27) and those are very similar so it doesn't cause
pain.

  Ralf

The patch is required on SMP systems as without it you get:

BUG: using smp_processor_id() in preemptible [00000000] code: cat/687
caller is show_cpuinfo+0xc4/0x500
Call Trace:
[<ffffffff8111f4c8>] dump_stack+0x8/0x38
[<ffffffff812c235c>] debug_smp_processor_id+0xec/0x100
[<ffffffff8112de64>] show_cpuinfo+0xc4/0x500
[<ffffffff811d4128>] seq_read+0x2f8/0x420
[<ffffffff811fb658>] proc_reg_read+0x90/0xd8
[<ffffffff811b05ec>] vfs_read+0xbc/0x160
[<ffffffff811b0a88>] sys_read+0x50/0x98
[<ffffffff81129224>] handle_sysn32+0x44/0x84


David Daney

<Prev in Thread] Current Thread [Next in Thread>