Re: [PATCH 2/2] show_cpuinfo prints the name of the calling CPU, which i think is wrong.

[David Daney <ddaney@caviumnetworks.com>]

Ralf Baechle wrote:
> On Mon, Oct 13, 2008 at 07:36:21PM +0200, Johannes Dickgreber wrote:
>
> > Cc: linux-mips@linux-mips.org
> > Subject: [PATCH 2/2] show_cpuinfo prints the name of the calling CPU, which i
> >         think is wrong.
> Patch is correct and so I applied it.  Not a big issue though.  There is
> only one system supported currently that supports a mix of different
> processor types (IP27) and those are very similar so it doesn't cause
> pain.
>
>   Ralf
The patch is required on SMP systems as without it you get:

BUG: using smp_processor_id() in preemptible [00000000] code: cat/687
caller is show_cpuinfo+0xc4/0x500
Call Trace:
[<ffffffff8111f4c8>] dump_stack+0x8/0x38
[<ffffffff812c235c>] debug_smp_processor_id+0xec/0x100
[<ffffffff8112de64>] show_cpuinfo+0xc4/0x500
[<ffffffff811d4128>] seq_read+0x2f8/0x420
[<ffffffff811fb658>] proc_reg_read+0x90/0xd8
[<ffffffff811b05ec>] vfs_read+0xbc/0x160
[<ffffffff811b0a88>] sys_read+0x50/0x98
[<ffffffff81129224>] handle_sysn32+0x44/0x84


David Daney