linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Add missing include in arch/mips/include/asm/ptrace.h.

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH] MIPS: Add missing include in arch/mips/include/asm/ptrace.h.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Sat, 11 Oct 2008 15:57:28 +0100
Cc: linux-mips@linux-mips.org, "Paoletti, Tomaso" <Tomaso.Paoletti@caviumnetworks.com>
In-reply-to: <48EFAF9E.9010806@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <48EFAF9E.9010806@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Oct 10, 2008 at 12:40:14PM -0700, David Daney wrote:

> Add missing include in arch/mips/include/asm/ptrace.h.
>
> Recent reorganization seems to have lost this include.  You cannot
> build without it.
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> Signed-off-by: Tomaso Paoletti <tpaoletti@caviumnetworks.com>
> ---
> arch/mips/include/asm/ptrace.h |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
> index 7fe9812..36872b8 100644
> --- a/arch/mips/include/asm/ptrace.h
> +++ b/arch/mips/include/asm/ptrace.h
> @@ -120,6 +120,8 @@ struct pt_watch_regs {
>
> #include <linux/compiler.h>
> #include <linux/linkage.h>
> +#include <linux/sched.h>

Sched.h is one of those include files that drag in way to many other
header files.  So I went for a forward declaration of struct task_struct
instead.

Thanks,

  Ralf

<Prev in Thread] Current Thread [Next in Thread>