linux-mips
[Top] [All Lists]

Re: [PATCH] serial: Add Cavium OCTEON UART definitions.

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH] serial: Add Cavium OCTEON UART definitions.
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Tue, 7 Oct 2008 11:29:32 +0100
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, "Paoletti, Tomaso" <Tomaso.Paoletti@caviumnetworks.com>
In-reply-to: <48EAAF97.8050307@caviumnetworks.com>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <48EAAF97.8050307@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
> +#ifdef CONFIG_CPU_CAVIUM_OCTEON
> +     /* UPF_FIXED_PORT indicates an internal UART.  */
> +     if (up->port.flags & UPF_FIXED_PORT)
> +             up->port.type = PORT_OCTEON;
> +     else
> +#endif

Not nice. Please keep CPU specific ifdefs out of the 8250 core code. Can
you not set a port flag for UPF_BROKEN_OCTEON or similar to clean that up
and also make the other tests that need things doing (eg the always
calling IRQ code use port flags of a more generic nature ?)

<Prev in Thread] Current Thread [Next in Thread>