linux-mips
[Top] [All Lists]

Re: [PATCH v2] IDE: Fix platform device registration in Swarm IDE driver

To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH v2] IDE: Fix platform device registration in Swarm IDE driver
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 3 Oct 2008 19:25:43 +0100
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>, linux-ide@vger.kernel.org, "Maciej W. Rozycki" <macro@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <200810031900.55214.bzolnier@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080922122853.GA15210@linux-mips.org> <20080928175450.GA8478@linux-mips.org> <48DFFC62.9050300@ru.mvista.com> <200810031900.55214.bzolnier@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Oct 03, 2008 at 07:00:54PM +0200, Bartlomiej Zolnierkiewicz wrote:

> > > The Swarm IDE driver uses a release method which is defined in the driver
> > > itself thus potentially oopsable.  The simple fix would be to just leak
> > > the device but this patch goes the full length and moves the entire
> > > handling of the platform device in the platform code and retains only
> > > the platform driver code in drivers/ide/mips/swarm.c.
> > >
> > > Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> 
> wow, v2 happened really quickly :)

It not just tidying up, it fixing a potencial crash so had to happen
quickly to (hopefully) make the release ...

> [ I removed no longer needed BLK_DEV_IDE_SWARM from ide/Kconfig while at it ]

Thanks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>