[Top] [All Lists]

Re: [PATCH v2] IDE: Fix platform device registration in Swarm IDE driver

To: Sergei Shtylyov <>
Subject: Re: [PATCH v2] IDE: Fix platform device registration in Swarm IDE driver
From: Bartlomiej Zolnierkiewicz <>
Date: Fri, 3 Oct 2008 19:00:54 +0200
Cc: Ralf Baechle <>,, "Maciej W. Rozycki" <>,
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version :content-disposition:message-id:content-type :content-transfer-encoding; bh=N+dE0NvGG5VhCY+OO9GxYMtoQVZ8n3Dj90YYtKf8+1U=; b=p0wis1vlPz12pyKC3H5RCmu9Xo34yNTZJGdhAEhrxkoLPrfRxFDuaTwEoyLAx1+0Nb Yh1+bHBHunboRY9SBrJ0D68OfewkIEzzSjNcUQHpG4QWKsRdXaifGQ6eOVUYOt5CCYXg uQC8OM1kfV6mrji3Ce4/p/eCX5IwjqYWHAxIU=
Domainkey-signature: a=rsa-sha1; c=nofws;; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-disposition:message-id:content-type :content-transfer-encoding; b=Xa5L1u29g/C/0OiZ91WF6lk4q4BC2UkkPs4vo/Imrzsqm7JH9U3k/jUYu6V0mt2OXJ N6K/dXZNWxSPT1cq/cJH0vWKwEBn+xVvGYngxTh+dCMPIeTyR/s8yXI2Gsr/2Z0lY21R 5RYePNa8MyvdCgr8QdToia03iloDp302zSOuA=
In-reply-to: <>
Original-recipient: rfc822;
References: <> <> <>
User-agent: KMail/1.9.10
On Sunday 28 September 2008, Sergei Shtylyov wrote:
> Hello.
> Ralf Baechle wrote:
> > The Swarm IDE driver uses a release method which is defined in the driver
> > itself thus potentially oopsable.  The simple fix would be to just leak
> > the device but this patch goes the full length and moves the entire
> > handling of the platform device in the platform code and retains only
> > the platform driver code in drivers/ide/mips/swarm.c.
> >
> > Signed-off-by: Ralf Baechle <>

wow, v2 happened really quickly :)

> Acked-by: Sergei Shtylyov <>


[ I removed no longer needed BLK_DEV_IDE_SWARM from ide/Kconfig while at it ]

<Prev in Thread] Current Thread [Next in Thread>