linux-mips
[Top] [All Lists]

Re: [PATCH v2] IDE: Fix platform device registration in Swarm IDE driver

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH v2] IDE: Fix platform device registration in Swarm IDE driver
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Mon, 29 Sep 2008 12:00:14 +0400
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>, linux-ide@vger.kernel.org, "Maciej W. Rozycki" <macro@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <48DFFC62.9050300@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080922122853.GA15210@linux-mips.org> <48DA1F9D.6000501@ru.mvista.com> <200809271859.55304.bzolnier@gmail.com> <20080928113931.GA9207@linux-mips.org> <20080928175450.GA8478@linux-mips.org> <48DFFC62.9050300@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.17 (Windows/20080914)
Hello, I wrote:

The Swarm IDE driver uses a release method which is defined in the driver
itself thus potentially oopsable.  The simple fix would be to just leak
the device but this patch goes the full length and moves the entire
handling of the platform device in the platform code and retains only
the platform driver code in drivers/ide/mips/swarm.c.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

Perhaps worth splitting into arch/mips/ and the follow-up drivers/ide/ patches though...

MBR, Sergei



<Prev in Thread] Current Thread [Next in Thread>