linux-mips
[Top] [All Lists]

Re: [PATCH] IDE: Fix platform device registration in Swarm IDE driver

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] IDE: Fix platform device registration in Swarm IDE driver
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Sun, 28 Sep 2008 16:51:08 +0400
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org, "Maciej W. Rozycki" <macro@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <20080928114711.GB9207@linux-mips.org>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080922122853.GA15210@linux-mips.org> <48DA1F9D.6000501@ru.mvista.com> <20080928114711.GB9207@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
Hello.

Ralf Baechle wrote:

+{

[...]

+       pdev = platform_device_register_simple(DEV_NAME, -1,
+                      swarm_ide_resource, ARRAY_SIZE(swarm_ide_resource));

If you have the resources as static array anyway, why not have the device in the static variable too and use platform_device_register()?

It saves a few lines of code.

And wastes few words of static data since platform_device_register_simple() will kmalloc() the resources and do a copy from these resources after which they are not needed -- so, it's worth making swarm_ide_resource[] __initdata at least. If you were using platform_device_register() with static platform device, no memory allocation would have happened, and no data would have been wasted.

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>