linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] ide: Add tx4939ide driver

To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH 1/2] ide: Add tx4939ide driver
From: Tejun Heo <htejun@gmail.com>
Date: Sun, 28 Sep 2008 07:09:35 +0900
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, sshtylyov@ru.mvista.com, linux-mips@linux-mips.org, linux-ide@vger.kernel.org, ralf@linux-mips.org, Jens Axboe <jens.axboe@oracle.com>, James Bottomley <James.Bottomley@HansenPartnership.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=Q5WiaKWW4VMhWf0r0P56Jdo0RjLCBkcot8F5YgaudE4=; b=vA3OxeuMIENXHhGf8UgOHdGEcYkXVmOEmba4EuB9m1QDV0Jng4o5SoDqWwD4zdGDC8 Ez/Jok24qZDfylM7eKCpyOf6eMkuN7cgCl7lcU5YC13zY3vSFMaWf6fBk3aLrMIaSqmY mCLlIQyIUWG55NZmZ5BIWXNksQCo0loDTNvSQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=DDXp/M/yT0+2J63Xsl0qohVz4YurPuweWpoXVKXHV3XoQRf9l2MwSL7YAVkKx8sp6F /OnMN3RMQSiKpnmTqtCnZd9gG01umkAp1reaKrY+1kXlw/EwO1Pxl8KeQPTHdhoGJ4Qt PWv3guYEhQ5xjQe1FjENInXGdz7smX1f4fNKM=
In-reply-to: <200809271819.19510.bzolnier@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <48C851ED.4090607@ru.mvista.com> <48CA8BEE.1090305@ru.mvista.com> <20080913.005904.07457691.anemo@mba.ocn.ne.jp> <200809271819.19510.bzolnier@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.16 (X11/20080720)
Bartlomiej Zolnierkiewicz wrote:
> On Friday 12 September 2008, Atsushi Nemoto wrote:
>> On Fri, 12 Sep 2008 19:34:06 +0400, Sergei Shtylyov 
>> <sshtylyov@ru.mvista.com> wrote:
> 
> [...]
> 
>>>>>> +        __ide_flush_dcache_range((unsigned long)addr, size);
>>>>>   Why is this needed BTW?
>>>> Do you mean __ide_flush_dcache_range?  This is needed to avoid cache
>>>> inconsistency on PIO drive.  PIO transfer only writes to cache but
>>>> upper layers expects the data is in main memory.
>>>     Hum, then I wonder why it's MIPS specific...
>> SPARC also have it.  And there were some discussions for ARM IIRC.
> 
> I was under the impression that it has been addressed by Tejun at
> the higher-layer level (for both ide/libata) long time ago and that
> MIPS/SPARC code are just a left-overs which could be removed now?

cc'ing Jens and James.  IIRC, I posted several patches but they never
went in.  I don't remember what the objections were or whether any
alternative fix went in.

Thanks.

-- 
tejun

<Prev in Thread] Current Thread [Next in Thread>