linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] ide: Add tx4939ide driver

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH 1/2] ide: Add tx4939ide driver
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: Sat, 27 Sep 2008 18:19:19 +0200
Cc: sshtylyov@ru.mvista.com, linux-mips@linux-mips.org, linux-ide@vger.kernel.org, ralf@linux-mips.org, Tejun Heo <htejun@gmail.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version :content-disposition:message-id:content-type :content-transfer-encoding; bh=prIJFq9Etlsu9ckcvUY6pde5xrdiWD4xSojP0vqfcec=; b=c/zNpYt4+iF/GP6iuTXufAW2HBQXb2Xrkyyg3/gFn9lVJ3tYK3R4y1Ufj+Lh1inhoU hYOrmFGjy90uTQd+8Nw3Qtvy57zqzEXwgmQALlWErGGMHqE05ODB/Rj78+DKcjUGWS/V oO0M2uNPaVHnMHbtcc+HoHsNacJWgQrPVE09o=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-disposition:message-id:content-type :content-transfer-encoding; b=seUbj4rFcyiL3HFV5J1W5U+LSczdKs0Cjbvx2Vo4VCzxXKk3OTSF8Jo0Lio7xjBJ9K 5LqxrvAj9iGbHz5A2j8PMrCj9nS2IZrrkF9QDOI+OfEutjoPot7jtXVMuWuK9R3ZA06i YgKCt09FH63KoA+bpKuvFon5mGI576FaqA/7o=
In-reply-to: <20080913.005904.07457691.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <48C851ED.4090607@ru.mvista.com> <48CA8BEE.1090305@ru.mvista.com> <20080913.005904.07457691.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.10
On Friday 12 September 2008, Atsushi Nemoto wrote:
> On Fri, 12 Sep 2008 19:34:06 +0400, Sergei Shtylyov <sshtylyov@ru.mvista.com> 
> wrote:

[...]

> > >>>+        __ide_flush_dcache_range((unsigned long)addr, size);
> > 
> > >>   Why is this needed BTW?
> > 
> > > Do you mean __ide_flush_dcache_range?  This is needed to avoid cache
> > > inconsistency on PIO drive.  PIO transfer only writes to cache but
> > > upper layers expects the data is in main memory.
> > 
> >     Hum, then I wonder why it's MIPS specific...
> 
> SPARC also have it.  And there were some discussions for ARM IIRC.

I was under the impression that it has been addressed by Tejun at
the higher-layer level (for both ide/libata) long time ago and that
MIPS/SPARC code are just a left-overs which could be removed now?

Thanks,
Bart

<Prev in Thread] Current Thread [Next in Thread>