linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] ide: Add tx4939ide driver (v2)

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH 1/2] ide: Add tx4939ide driver (v2)
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: Sat, 27 Sep 2008 18:19:56 +0200
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, linux-mips@linux-mips.org, linux-ide@vger.kernel.org, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version :content-disposition:message-id:content-type :content-transfer-encoding; bh=poV7QGnwta0GKbX0Cp9vX/gabeukV9N1zveG2XoqGkk=; b=OISrOLDaAUcAdO8Fu+xemBrIGgJImbNaw4UKl89bbaYbmNlY3Cg0EcssuGw3RwjgPM WtcDNFcw2XTbTt2rquCbT++mYsF7OHjP8ed8ukO40yIAliURjtRG/IetHVi6+3RSOTK/ QRRXVamdjpZ0ALSL2HjGnstU8EpuwbxRS2BB0=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-disposition:message-id:content-type :content-transfer-encoding; b=rdSKYSuKjGHY/Kn4uUmBZrxBP8tXOdd7b/hRw8QwIJ9eOdb7ZngYe6q0vYuO0R9opM gsRyHNwlxF+2Je/p0XTstGPClwezjQ645BmQLUBBN4H+d7jkSeP1HMX8WUdAOx1Y0QHV +awMKDvNl9LDsgRIWh2ulf4q1zFWLOen8mo0k=
In-reply-to: <48D57245.8060606@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080918.001342.52129176.anemo@mba.ocn.ne.jp> <48D57245.8060606@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.10
On Saturday 20 September 2008, Sergei Shtylyov wrote:

[...]

>    But actually setting the controller's timings prior to issuing SET 
> FEATURES doesn't seem safe anyway. Bart, don't you think that we should 
> always call set_{dma|pio}_mode() AFTER ide_config_drive_speed() --
> we have no guarantee that the drive will accept the mode...

I remember some discussion about this issue in the past but currently I
don't see a reason why we shouldn't do it this way.  Care to make a patch?

Thanks,
Bart

<Prev in Thread] Current Thread [Next in Thread>