linux-mips
[Top] [All Lists]

Re: [PATCH 1/6] [MIPS] BCM47xx: Add platform specific PCI code

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH 1/6] [MIPS] BCM47xx: Add platform specific PCI code
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 26 Sep 2008 16:42:34 +0100
Cc: Aurelien Jarno <aurelien@aurel32.net>, linux-mips@linux-mips.org, Michael Buesch <mb@bu3sch.de>
In-reply-to: <48DABBBE.7060201@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080924191840.GA18700@volta.aurel32.net> <20080924191955.GB18700@volta.aurel32.net> <48DABBBE.7060201@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Sep 25, 2008 at 02:14:22AM +0400, Sergei Shtylyov wrote:

>> +    res = ssb_pcibios_map_irq(dev, slot, pin);
>> +    if (res < 0) {
>> +            printk(KERN_ALERT "PCI: Failed to map IRQ of device %s\n",
>> +                   dev->dev.bus_id);
>> +            return 0;
>> +    }
>> +    /* IRQ-0 and IRQ-1 are software interrupts. */
>> +    WARN_ON((res == 0) || (res == 1));
>>   
>
>   Unneeded ()...

My rule of thumb for the use of parenthesis is that the reader of a piece
of code should not have to know much about operator precendence, so the
occasional avoidable parenthesis if it serves readability.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>