linux-mips
[Top] [All Lists]

Re: [PATCH 1/6] [MIPS] BCM47xx: Add platform specific PCI code

To: "John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH 1/6] [MIPS] BCM47xx: Add platform specific PCI code
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Thu, 25 Sep 2008 13:54:08 +0400
Cc: Aurelien Jarno <aurelien@aurel32.net>, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, Michael Buesch <mb@bu3sch.de>
In-reply-to: <20080925001433.GA3496@tuxdriver.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080924191840.GA18700@volta.aurel32.net> <20080924191955.GB18700@volta.aurel32.net> <48DABBBE.7060201@ru.mvista.com> <20080925001433.GA3496@tuxdriver.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.16 (Windows/20080708)
Hello.

John W. Linville wrote:

This patch, ported from OpenWRT SVN, defines pcibios_map_irq() and
pcibios_plat_dev_init() for the BCM47xx platform.

It fixes the regression introduced by commit
aab547ce0d1493d400b6468c521a0137cd8c1edf.

Did you read this part?

I usually comment on the patches regardless of such stuff. Maybe I shoudn't have this time in order to not take the blame for the patch bot being merged...

+       if (err) {
+               printk(KERN_ALERT "PCI: Failed to init device %s\n",
+                      pci_name(dev));
+       }
  Unneeded {}...

This is petty bullshit...

  No, just style nitpicking. :-)

Is there a real reason why this hasn't been merged?

  This question is not to me.

John

WBR, Sergei



<Prev in Thread] Current Thread [Next in Thread>