[Top] [All Lists]

Re: [PATCH 1/6] [MIPS] BCM47xx: Add platform specific PCI code

To: "John W. Linville" <>
Subject: Re: [PATCH 1/6] [MIPS] BCM47xx: Add platform specific PCI code
From: Sergei Shtylyov <>
Date: Thu, 25 Sep 2008 13:54:08 +0400
Cc: Aurelien Jarno <>, Ralf Baechle <>,, Michael Buesch <>
In-reply-to: <>
Original-recipient: rfc822;
References: <> <> <> <>
User-agent: Thunderbird (Windows/20080708)

John W. Linville wrote:

This patch, ported from OpenWRT SVN, defines pcibios_map_irq() and
pcibios_plat_dev_init() for the BCM47xx platform.

It fixes the regression introduced by commit

Did you read this part?

I usually comment on the patches regardless of such stuff. Maybe I shoudn't have this time in order to not take the blame for the patch bot being merged...

+       if (err) {
+               printk(KERN_ALERT "PCI: Failed to init device %s\n",
+                      pci_name(dev));
+       }
  Unneeded {}...

This is petty bullshit...

  No, just style nitpicking. :-)

Is there a real reason why this hasn't been merged?

  This question is not to me.


WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>