linux-mips
[Top] [All Lists]

Re: [PATCH 1/6] [MIPS] BCM47xx: Add platform specific PCI code

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH 1/6] [MIPS] BCM47xx: Add platform specific PCI code
From: Michael Buesch <mb@bu3sch.de>
Date: Thu, 25 Sep 2008 00:31:00 +0200
Cc: Aurelien Jarno <aurelien@aurel32.net>, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <48DABBBE.7060201@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080924191840.GA18700@volta.aurel32.net> <20080924191955.GB18700@volta.aurel32.net> <48DABBBE.7060201@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.6 (enterprise 0.20070907.709405)
On Thursday 25 September 2008 00:14:22 Sergei Shtylyov wrote:
> > +   WARN_ON((res == 0) || (res == 1));
>
>    Unneeded ()...

> > +   err = ssb_pcibios_plat_dev_init(dev);
> > +   if (err) {
> > +           printk(KERN_ALERT "PCI: Failed to init device %s\n",
> > +                  pci_name(dev));
> > +   }
> >   
> 
>    Unneeded {}...


You must me kidding.
Get this freaking regression fix upstream, please.
We're not going to respin it to fix trivial taste issues.
(The above code is _perfectly_ fine and doesn't violate any rule).

-- 
Greetings Michael.

<Prev in Thread] Current Thread [Next in Thread>