linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] ide: Add tx4939ide driver (v2)

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH 1/2] ide: Add tx4939ide driver (v2)
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Sun, 21 Sep 2008 13:21:19 +0400
Cc: linux-mips@linux-mips.org, linux-ide@vger.kernel.org, ralf@linux-mips.org
In-reply-to: <48D57245.8060606@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080918.001342.52129176.anemo@mba.ocn.ne.jp> <48D57245.8060606@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.16 (Windows/20080708)
Hello, I wrote:

This controller has standard ATA taskfile registers and DMA
command/status registers, but the register layout is swapped on big
endian.  There are some other endian issue and some special registers
which requires many custom dma_ops/port_ops routines.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

I thought that I'd only have the stylyistic comments and ACK the patch but it shouldn't even compile... :-/

  Hm, it should compile in the context of linux-next tree..

+static void tx4939ide_set_pio_mode(ide_drive_t *drive, const u8 pio)
+{
+    ide_hwif_t *hwif = HWIF(drive);
+    int is_slave = drive->dn & 1;
+    u32 mask, val;
+    u8 safe = pio;
+    ide_drive_t *pair;
+
+    pair = ide_get_pair_dev(drive);

Wait, have you tried to compile this driver? The function is called ide_get_paired_drive() -- and I did name it correctly in my previous review.

I didn't realize that Bart has renamed the function in one of the pending patches...

MBR, Sergei



<Prev in Thread] Current Thread [Next in Thread>