linux-mips
[Top] [All Lists]

Re: [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early IRQ e

To: Jeff Garzik <jgarzik@redhat.com>
Subject: Re: [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early IRQ enable
From: Ralf Baechle <ralf@linux-mips.org>
Date: Sat, 20 Sep 2008 22:18:39 +0200
Cc: Weiwei Wang <weiwei.wang@windriver.com>, linux-mips@linux-mips.org, netdev@vger.kernel.org
In-reply-to: <20080917114051.GA30734@shell.devel.redhat.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <6781da3918e3c34d23e5f7e9cf777ab463a17d5e.1221613284.git.weiwei.wang@windriver.com> <20080917114051.GA30734@shell.devel.redhat.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Sep 17, 2008 at 07:40:51AM -0400, Jeff Garzik wrote:

> On Wed, Sep 17, 2008 at 10:25:37AM +0800, Weiwei Wang wrote:
> > Netpoll will call the interrupt handler with interrupts
> > disabled when using kgdboe, so spin_lock_irqsave() should
> > be used instead of spin_lock_irq() to prevent interrupts
> > from being incorrectly enabled.
> > 
> > Signed-off-by: Weiwei Wang <weiwei.wang@windriver.com>
> > ---
> >  drivers/net/sb1250-mac.c |   12 +++++++-----
> >  1 files changed, 7 insertions(+), 5 deletions(-)
> 
> Please send to jeff@garzik.org or jgarzik@pobox.com.

Jeff - I haven't looked at kgdboe but if he's right half of drivers/net
will need to be fixed ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>