Re: [PATCH] MIPS checksum fix

[Ralf Baechle <ralf@linux-mips.org>]

On Fri, Sep 19, 2008 at 11:09:52PM +0900, Atsushi Nemoto wrote:

> I think it would be better splitting bugfix and optimization.  This
> code is too complex to do many things at a time, isn't it?
> 
> > @@ -53,12 +53,14 @@
> >  #define UNIT(unit)  ((unit)*NBYTES)
> >  
> >  #define ADDC(sum,reg)                                              \
> > -   .set    push;                                           \
> > -   .set    noat;                                           \
> >     ADD     sum, reg;                                       \
> >     sltu    v1, sum, reg;                                   \
> >     ADD     sum, v1;                                        \
> > -   .set    pop
> 
> Is this required?  Just a cleanup?

It papers over potencially important warnings so had to go.  I argue the
caller of ADDC should set noat mode, if at all.

  Ralf