linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS checksum fix

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS checksum fix
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Fri, 19 Sep 2008 13:15:38 +0100 (BST)
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, u1@terran.org, linux-mips@linux-mips.org, netdev@vger.kernel.org
In-reply-to: <20080919120752.GA19877@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.55.0809171104290.17103@cliff.in.clinika.pl> <20080917.222350.41199051.anemo@mba.ocn.ne.jp> <Pine.LNX.4.55.0809171501450.17103@cliff.in.clinika.pl> <20080918.002705.78730226.anemo@mba.ocn.ne.jp> <Pine.LNX.4.55.0809171917580.17103@cliff.in.clinika.pl> <20080918220734.GA19222@linux-mips.org> <Pine.LNX.4.55.0809190112090.22686@cliff.in.clinika.pl> <20080919112304.GB13440@linux-mips.org> <20080919114743.GA19359@linux-mips.org> <20080919120752.GA19877@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 19 Sep 2008, Ralf Baechle wrote:

> +     beqz    t7, 1f                  /* odd buffer alignment? */
> +      lui    v1, 0x00ff

 Well, .set reorder to move something from before the branch would have 
been a little bit better for the common aligned case. ;)  There is nothing 
special about branch delay slots in the whole epilogue, so one from just 
before the return might simply be relocated here.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>