linux-mips
[Top] [All Lists]

Re: [PATCH] gpio_free might sleep, mips architecture

To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] gpio_free might sleep, mips architecture
From: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
Date: Thu, 18 Sep 2008 11:32:42 +0200
Cc: linux-kernel@vger.kernel.org, david-b@pacbell.net, ralf@linux-mips.org, linux-mips@linux-mips.org, g.liakhovetski@pengutronix.de, greg@kroah.com, kay.sievers@vrfy.org, rmk+kernel@arm.linux.org.uk
In-reply-to: <20080917143955.2d3727e5.akpm@linux-foundation.org>
Mail-followup-to: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>, Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, david-b@pacbell.net, ralf@linux-mips.org, linux-mips@linux-mips.org, g.liakhovetski@pengutronix.de, greg@kroah.com, kay.sievers@vrfy.org, rmk+kernel@arm.linux.org.uk
Organization: Universitaet Freiburg, Institut f. Informatik
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1216884515-12084-1-git-send-email-Uwe.Kleine-Koenig@digi.com> <1221508963-27259-1-git-send-email-ukleinek@informatik.uni-freiburg.de> <1221508963-27259-2-git-send-email-ukleinek@informatik.uni-freiburg.de> <1221508963-27259-3-git-send-email-ukleinek@informatik.uni-freiburg.de> <20080917143955.2d3727e5.akpm@linux-foundation.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.13 (2006-08-11)
Hello,

Andrew Morton wrote:
> > diff --git a/include/asm-mips/mach-rc32434/gpio.h 
> > b/include/asm-mips/mach-rc32434/gpio.h
> > index f946f5f..9b4722e 100644
> > --- a/include/asm-mips/mach-rc32434/gpio.h
> > +++ b/include/asm-mips/mach-rc32434/gpio.h
> > @@ -13,6 +13,7 @@
> >  #ifndef _RC32434_GPIO_H_
> >  #define _RC32434_GPIO_H_
> >  
> > +#include <linux/kernel.h>
> >  #include <linux/types.h>
> >  
> >  struct rb532_gpio_reg {
> > @@ -88,6 +89,7 @@ static inline int gpio_request(unsigned gpio, const char 
> > *label)
> >  static inline void gpio_free(unsigned gpio)
> >  {
> >     /* Not yet implemented */
> > +   might_sleep();
> >  }
> >  
> 
> There is no gpio_free() in linux-next's include/asm-mips/mach-rc32434/gpio.h
This is OK.  This machine type is converted to GPIO lib in linus-next.
So just drop the two hunks for this file.  (Note, you only dropped the
addition of might_sleep, but then including linux/kernel.h isn't needed
either.)

Best regards and thanks
Uwe

-- 
Uwe Kleine-König

exit vi, lesson II:
: w q ! <CR>

NB: write the current file

<Prev in Thread] Current Thread [Next in Thread>