linux-mips
[Top] [All Lists]

Re: [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early IRQ e

To: Weiwei Wang <weiwei.wang@windriver.com>
Subject: Re: [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early IRQ enable
From: Jeff Garzik <jgarzik@redhat.com>
Date: Wed, 17 Sep 2008 07:40:51 -0400
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <6781da3918e3c34d23e5f7e9cf777ab463a17d5e.1221613284.git.weiwei.wang@windriver.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <6781da3918e3c34d23e5f7e9cf777ab463a17d5e.1221613284.git.weiwei.wang@windriver.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.2i
On Wed, Sep 17, 2008 at 10:25:37AM +0800, Weiwei Wang wrote:
> Netpoll will call the interrupt handler with interrupts
> disabled when using kgdboe, so spin_lock_irqsave() should
> be used instead of spin_lock_irq() to prevent interrupts
> from being incorrectly enabled.
> 
> Signed-off-by: Weiwei Wang <weiwei.wang@windriver.com>
> ---
>  drivers/net/sb1250-mac.c |   12 +++++++-----
>  1 files changed, 7 insertions(+), 5 deletions(-)

Please send to jeff@garzik.org or jgarzik@pobox.com.

        Jeff




<Prev in Thread] Current Thread [Next in Thread>