Re: [PATCH 1/2] ide: Add tx4939ide driver

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Atsushi Nemoto wrote:

> > > >   This doesn't look consistent (aside from the TX4939IDE_REG8/16 issue) 
> > > > -- mm_outsw_swap() calls cpu_to_le16() before writing 16-bit data but 
> > > > this code doesn't. So, either one of those should be wrong...
> > > Thanks, this code should be wrong.  IDE_TFLAG_OUT_DATA is totally
> > > untested...
> >   Hum, not necessarily...
> >   If the data register is BE, this should work correctly, if I don't 
> > mistake (once you fix the data register's address).
> Hmm... or ide_tf_load()/ide_tf_read() is broken for big endian MIPS ?
> (and possibly SPARC etc.)
   Probably it is. But hardly anybody cares -- as I said, that flag seems 
totally useless.
> __ide_mm_writesw(port, &data, 1) should be used instead of writew()
> for IDE_TFLAG_OUT_DATA?
MBR, Sergei