linux-mips
[Top] [All Lists]

Re: [PATCH] [MIPS] vr41xx: unsigned irq cannot be negative

To: roel kluin <roel.kluin@gmail.com>
Subject: Re: [PATCH] [MIPS] vr41xx: unsigned irq cannot be negative
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Tue, 16 Sep 2008 14:44:21 +0400
Cc: ralf@linux-mips.org, yoichi_yuasa@tripeaks.co.jp, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <48CF02EE.8050406@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <48CF02EE.8050406@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.16 (Windows/20080708)
Hello.

roel kluin wrote:

unsigned irq cannot be negative

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/arch/mips/vr41xx/common/irq.c b/arch/mips/vr41xx/common/irq.c
index cba36a2..92dd1a0 100644
--- a/arch/mips/vr41xx/common/irq.c
+++ b/arch/mips/vr41xx/common/irq.c
@@ -72,6 +72,7 @@ static void irq_dispatch(unsigned int irq)
        cascade = irq_cascade + irq;
        if (cascade->get_irq != NULL) {
                unsigned int source_irq = irq;
+               int ret;

  Keep an empty line after the declaration block please.

@@ -79,8 +80,9 @@ static void irq_dispatch(unsigned int irq)
                        desc->chip->mask(source_irq);
                        desc->chip->ack(source_irq);
                }
-               irq = cascade->get_irq(irq);
-               if (irq < 0)
+               ret = cascade->get_irq(irq);
+               irq = ret;
+               if (ret < 0)
                        atomic_inc(&irq_err_count);
                else
                        irq_dispatch(irq);

 How about this:

                ret = cascade->get_irq(irq);
                if (ret < 0)
                        atomic_inc(&irq_err_count);
                else
                        irq_dispatch(ret);


WBR, Sergei



<Prev in Thread] Current Thread [Next in Thread>