| To: | Kevin Hickey <khickey@rmicorp.com> |
|---|---|
| Subject: | Re: [PATCH] Au1200 USB Device Controller and device-only OTG |
| From: | David Brownell <david-b@pacbell.net> |
| Date: | Mon, 15 Sep 2008 12:16:01 -0700 |
| Cc: | linux-mips@linux-mips.org, ralf@linux-mips.org, linux-usb@vger.kernel.org, mano@roarinelk.homelinux.net |
| Domainkey-signature: | a=rsa-sha1; q=dns; c=nofws; s=s1024; d=pacbell.net; h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id; b=jFGNr1LgyRnr4E3jhHKnBsPdIukz73gEIHCnxaSX4mCuYJ/vq8FfrL2+FlVcPXVAy4uKHNbMCXNiHFEo2/pV8WqAov3Xmb5979ZpyZ0qDkeajhd+DU75a+bIfdFnRJPI44qCi+gCnvvC5SCvv00Yjz2vMCja2rUwOOaTRpy2LNI= ; |
| In-reply-to: | <1221155967-25502-1-git-send-email-khickey@rmicorp.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <> <1221155967-25502-1-git-send-email-khickey@rmicorp.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | KMail/1.9.9 |
On Thursday 11 September 2008, Kevin Hickey wrote:
> basic device-only OTG (On-The-Go) support
That does't look like it's done right. For starters, it abuses
Kconfig to handle a board-specific config option. Put that data
in platform_data instead ...
Second, it breaks some previously-working code.
Third, it misbehaves even on an x86 config. Needs something like
the appended patch.
- Dave
--- g26.orig/drivers/usb/gadget/Kconfig 2008-09-15 12:10:22.000000000 -0700
+++ g26/drivers/usb/gadget/Kconfig 2008-09-15 12:10:06.000000000 -0700
@@ -490,7 +490,7 @@ config USB_GADGET_DUALSPEED
config USB_PORT_AU1200OTG
boolean "AU1200 USB portmux control (On-The-Go support)"
- depends on USB_GADGET_AU1200 || USB_EHCI_HCD || USB_OHCI_HCD
+ depends on USB_GADGET_AU1200 && (USB_EHCI_HCD || USB_OHCI_HCD)
default n
help
The AU1200 and Au1200 USB device port can be used as either a host
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] [MIPS] vr41xx: unsigned irq cannot be negative, roel kluin |
|---|---|
| Next by Date: | Re: [PATCH] Au1200 USB Device Controller and device-only OTG, Kevin Hickey |
| Previous by Thread: | [PATCH] Au1200 USB Device Controller and device-only OTG, Kevin Hickey |
| Next by Thread: | Re: [PATCH] Au1200 USB Device Controller and device-only OTG, Kevin Hickey |
| Indexes: | [Date] [Thread] [Top] [All Lists] |