linux-mips
[Top] [All Lists]

Re: [PATCH] sparse: Make pre_buffer dynamically increasable

To: "Atsushi Nemoto" <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] sparse: Make pre_buffer dynamically increasable
From: "Christopher Li" <sparse@chrisli.org>
Date: Sat, 13 Sep 2008 10:59:45 -0700
Cc: linux-sparse@vger.kernel.org, linux-mips@linux-mips.org, sam@ravnborg.org, viro@zeniv.linux.org.uk
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type:references :x-google-sender-auth; bh=C/iz/kEWta2BHqB+7CdelL6jqWXQRWvI7kBxG+CTIvg=; b=TcYHea6sn/tZ0jteSIL1bxKob8tfAckr6EwWd/2Mk9W/MB0L6aZIli4ywcISh19tXf 0AMZf0PGNUd4AWzWH5lx37eVDiTIIqAVsv13DtoufPHnLj3kqmZD5hOqVrr5T5mnpVn+ qx4izmwbqXKyweAmqkFm7KySlW9h+DEFjXllA=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:references:x-google-sender-auth; b=vaFUt1xFFTaUsgQw5QDFF+r3IDU0dhY/mLZGuRKO5RcrX7+ppOl3cCOR64hy21iHV+ PL4J3rX8gdOH9OkKthX0qX9oc0N+9IYvkxoHd0Q88L3GvPw2oVzEnP5ZYbCHG8RaKwR+ knBTxbaIe0tmkWCUiBumubPzYCuX4pDO0gfA4=
In-reply-to: <20080914.004951.41872502.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080720.002224.108306935.anemo@mba.ocn.ne.jp> <20080914.004951.41872502.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
On Sat, Sep 13, 2008 at 8:49 AM, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
>> This patch make pre_buffer dynamically increasable and add extra
>> checking for overflow instead of silently truncating.
>>

The better way is just remove the pre_buffer completely. Just tokenize
the buffer
and append the result token on the fly.

Can you try out the patch I attached? It does just that.

Chris

Attachment: pre-buffer-tokenize
Description: Binary data

<Prev in Thread] Current Thread [Next in Thread>