linux-mips
[Top] [All Lists]

Re: [PATCH] rb532: do not use phys_t

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] rb532: do not use phys_t
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Thu, 11 Sep 2008 17:15:42 +0100 (BST)
Cc: ralf@linux-mips.org, Linux MIPS Org <linux-mips@linux-mips.org>
In-reply-to: <200809111755.41730.florian@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200809111755.41730.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 11 Sep 2008, Florian Fainelli wrote:

> MIPS include types.h says that using phys_t is bad, which in
> fact is an unsigned long, so use an unsigned long directly.

 That is bad indeed.  A physical address might not fit in unsigned long.  
Actually the upstream is apparently adopting phys_addr_t for this purpose 
right now, so you might consider waiting with your patch till the thing 
settles down.  Note that by using a generic type you take away semantics 
which will make future adjustments more difficult.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>