| To: | Julien Brunel <brunel@diku.dk> |
|---|---|
| Subject: | Re: [PATCH] fs/ubifs: Use an IS_ERR test rather than a NULL test |
| From: | Artem Bityutskiy <dedekind@infradead.org> |
| Date: | Fri, 29 Aug 2008 13:35:14 +0300 |
| Cc: | linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org |
| In-reply-to: | <200808291108.32958.brunel@diku.dk> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <200808291108.32958.brunel@diku.dk> |
| Reply-to: | dedekind@infradead.org |
| Sender: | linux-mips-bounce@linux-mips.org |
On Fri, 2008-08-29 at 11:08 +0200, Julien Brunel wrote: > In case of error, the function kthread_create returns an ERR pointer, > but never returns a NULL pointer. So a NULL test that comes before an > IS_ERR test should be deleted. > > The semantic match that finds this problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) Pushed to ubifs-2.6.git, thanks. -- Best regards, Artem Bityutskiy (Битюцкий Артём) |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] fs/ubifs: Use an IS_ERR test rather than a NULL test, Julien Brunel |
|---|---|
| Next by Date: | Re: [Patch 0/6] MIPS: Hardware watch register support for gdb (version 3)., David Daney |
| Previous by Thread: | [PATCH] fs/ubifs: Use an IS_ERR test rather than a NULL test, Julien Brunel |
| Next by Thread: | [PATCH] IP22: Fix handling of memory for I2 with more than 256MB, Thomas Bogendoerfer |
| Indexes: | [Date] [Thread] [Top] [All Lists] |